Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage of prettier in order to have a clear coding standard #607

Merged
merged 5 commits into from
Feb 23, 2021

Conversation

christianlupus
Copy link
Collaborator

Prettier is used to format all vue files in the project. Most of the changed in this PR are automatically generated. Some minor modifications are added to address shortcomings of the translation engine of the NC docker-ci repo.

This PR enables the prettier plugin in the code linter workflow as well.

Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
The current implementation to detect translation strings uses a
one-line regex. So we must keep all translations on one line.

Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
@codecov
Copy link

codecov bot commented Feb 23, 2021

Codecov Report

Merging #607 (483033a) into master (341f444) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #607   +/-   ##
========================================
  Coverage      1.01%   1.01%           
  Complexity      444     444           
========================================
  Files            14      14           
  Lines          1385    1385           
========================================
  Hits             14      14           
  Misses         1371    1371           
Flag Coverage Δ Complexity Δ
integration 0.00% <ø> (ø) 0.00 <ø> (ø)
unittests 1.01% <ø> (ø) 0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus christianlupus merged commit f88a32b into master Feb 23, 2021
@delete-merged-branch delete-merged-branch bot deleted the dev/pretty-vue-files branch February 23, 2021 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant